Last modified: 2011-01-02 10:31:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28540, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26540 - Wrong call to applyPatch in MysqlUpdater
Wrong call to applyPatch in MysqlUpdater
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-02 07:59 UTC by Stefan S
Modified: 2011-01-02 10:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Stefan S 2011-01-02 07:59:41 UTC 
i try to upgrade to 1.17.
update.php is complaing about a missing applyPatch function.


changing
                        $this->db->applyPatch( $patchFile );
to
                        $this->applyPatch( $patchFile );

in includes/installer/MysqlUpdater.php on line 194 will fix this issue.
Comment 1 Sam Reed (reedy) 2011-01-02 08:06:05 UTC 
r79480 in SVN

Thanks!
Comment 2 Stefan S 2011-01-02 10:21:45 UTC 
its still db-> in 79485 can you add it to branch http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_17/phase3/includes/installer/MysqlUpdater.php or did you change it that it works with db?
Comment 3 Roan Kattouw 2011-01-02 10:27:05 UTC 
(In reply to comment #2)
> its still db-> in 79485 can you add it to branch
> http://svn.wikimedia.org/svnroot/mediawiki/branches/REL1_17/phase3/includes/installer/MysqlUpdater.php
> or did you change it that it works with db?
The revision hasn't been merged to the branch yet. I merged another batch recently and we've currently got just one reviewed revision ready for backporting (the fix for this bug), so I'll wait until there are a few more in the queue (or other existing revisions in the queue get reviewed) before I backport another batch. This'll probably happen on Tuesday or Wednesday.
Comment 4 Roan Kattouw 2011-01-02 10:31:26 UTC 
Reclosing as FIXED because that's what we do once bugs are fixed in trunk.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links