Last modified: 2010-12-30 14:16:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26507 - Have RL wrap all modules in (function($) { ... })(jQuery); to prevent noConflict() interference
Have RL wrap all modules in (function($) { ... })(jQuery); to prevent noConfl...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Normal critical (vote)
: ---
Assigned To: Roan Kattouw
http://biowikifarm.net/test/Special:P...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-30 11:13 UTC by Gregor Hagedorn
Modified: 2010-12-30 14:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gregor Hagedorn 2010-12-30 11:13:48 UTC
With both a few day old revision and the newest SVN r.79244, skin: Vector:

Going to user preferences, the pages (User profile, Appearance, Date and time, Editing, etc.) appear correctly as tabs. However, clicking on any of these tabs results in no action - the javascript functionality behind is not working.

It could be a problem in combination with jquery. In principle, jquery is being loaded, we have Vector-extension running and the hideable menus on the left are ok. However, we have code in Mediawiki:Common.js, which is unable to pick up the jquery. Should the preferences-tab-click be implemented through jquery, there may thus be a more generic jquery problem behind it.
Comment 1 Roan Kattouw 2010-12-30 11:16:22 UTC
I can't diagnose this without being able to view Special:Preferences, which I can't do without an account, which I can't create other than through a Citizendium-like request procedure. Can you give me a test account so I can poke at this?
Comment 2 Roan Kattouw 2010-12-30 11:38:48 UTC
Thanks for setting me up with a test account.

This line appears in the HTML source of your pages and should be removed:
<script type="text/javascript">var $j=jQuery.noConflict();</script>

Although of course the real issue is that some modules aren't properly wrapped in (function($) { ... })(jQuery); , which should really be done for *all* modules by the resource loader itself. Repurposing this bug for that.
Comment 3 Roan Kattouw 2010-12-30 12:23:25 UTC
(In reply to comment #2)
> Although of course the real issue is that some modules aren't properly wrapped
> in (function($) { ... })(jQuery); , which should really be done for *all*
> modules by the resource loader itself. Repurposing this bug for that.
This was done in r79246. I also fixed some JS errors on the preferences page in r79245.
Comment 4 Gregor Hagedorn 2010-12-30 14:16:45 UTC
I confirm that the root cause for the failing preferences is the jQuery.noConflict() setting.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links