Last modified: 2014-01-17 07:47:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28503, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26503 - imagelinks not updated for cascade protection
imagelinks not updated for cascade protection
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page protection (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-30 09:58 UTC by Umherirrender
Modified: 2014-01-17 07:47 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2010-12-30 09:58:11 UTC 
Cascadeprotection of images working with the imagelinks (see Title::getCascadeProtectionSources).

But when there are no templatelinks changes after a purge the method doCascadeProtectionUpdates does not start a LinksUpdate even imagelinks are changed.

Thanks.
Comment 1 Umherirrender 2010-12-31 15:34:57 UTC 
When a cascade protected page contains time-dependent imagelinks than the imagelinks table is not updated after a purge of the cascade protected page and so the wrong image is cascade protected.

It works when there are also templatelinks to update, because Article::doCascadeProtectionUpdates handles the special case of time-dependent transclusion of templates. It is called when the html page is parsed the first time after the purge.
Comment 2 Gerrit Notification Bot 2014-01-06 21:31:11 UTC 
Change 105830 had a related patch set uploaded by Anomie:
Make imagelinks work like templatelinks

https://gerrit.wikimedia.org/r/105830
Comment 3 Gerrit Notification Bot 2014-01-07 23:17:45 UTC 
Change 105830 merged by jenkins-bot:
Make imagelinks work like templatelinks

https://gerrit.wikimedia.org/r/105830
Comment 4 Brad Jorsch 2014-01-08 16:47:26 UTC 
Should be deployed to WMF wikis with 1.23wmf10, see https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links