Last modified: 2011-01-05 22:12:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28480, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26480 - add a pppageprops param to prop=pageprops
add a pppageprops param to prop=pageprops
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-29 20:35 UTC by db [inactive,noenotif]
Modified: 2011-01-05 22:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2010-12-29 20:35:54 UTC
It is possible to add a "pppageprops" param, which only list specified page props?. "Useful for checking whether a certain page uses a certain page prop."

Thanks.
Comment 1 Bryan Tong Minh 2010-12-29 20:38:41 UTC
We would need to track somewhere which pageprops exist, which I don't really want to do. Or make it an unvalidated string param.
Comment 2 db [inactive,noenotif] 2010-12-29 20:53:23 UTC
In my opinion a "unvalidated string param" is enough.
Comment 3 db [inactive,noenotif] 2010-12-29 21:14:40 UTC
Maybe "Useful for checking whether a certain page *has* a certain page prop." is better, as description. Because a page has props and not use it.
Comment 4 Sam Reed (reedy) 2010-12-30 01:00:01 UTC
(In reply to comment #1)
> We would need to track somewhere which pageprops exist, which I don't really
> want to do. Or make it an unvalidated string param.

IIRC, didn't Soxred93 do something like that originally, which you reverted that part and cleaned up

(Don't take that as me disagreeing with what you did though! :))
Comment 5 Bryan Tong Minh 2010-12-30 10:11:50 UTC
Indeed
Comment 6 Sam Reed (reedy) 2011-01-05 03:20:02 UTC
-- Name/value pairs indexed by page_id
CREATE TABLE /*_*/page_props (
  pp_page int NOT NULL,
  pp_propname varbinary(60) NOT NULL,
  pp_value blob NOT NULL
) /*$wgDBTableOptions*/\G

CREATE UNIQUE INDEX /*i*/pp_page_propname ON /*_*/page_props (pp_page,pp_propname)\G



Having already filtered by a page... Filtering by a propname afterwards, wouldn't to too expensive (thinking about if we left it as an unvalidated input string)
Comment 7 Sam Reed (reedy) 2011-01-05 22:12:12 UTC
r79675

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links