Last modified: 2012-09-27 01:10:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28459, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26459 - The renderNavigation and renderPortals functions should be protected or public instead of private
The renderNavigation and renderPortals functions should be protected or publi...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.18.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-28 17:15 UTC by Christian Neubauer
Modified: 2012-09-27 01:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Change private functions in Vector.php to protected (14.68 KB, patch)
2012-01-19 13:36 UTC, Christian Neubauer 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neubauer 2010-12-28 17:15:42 UTC 
The renderNavigation and renderPortals functions in Vector contain all kinds of useful stuff that a developer should be able to override in a sub class.
Comment 1 Mark A. Hershberger 2011-01-29 01:16:12 UTC 
This sort of comment really belongs in CodeReview.  See r53210 where I've made just this comment (prompted by this bug).
Comment 2 Bugmeister Bot 2011-08-19 19:12:55 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Christian Neubauer 2012-01-19 13:36:25 UTC 
Created attachment 9867 [details]
Change private functions in Vector.php to protected

(In reply to comment #1)
> This sort of comment really belongs in CodeReview.  See r53210 where I've made
> just this comment (prompted by this bug).

Thanks, I'll do that next time.  If I knew Trevor's email address, I would probably add him to the cc list too so he would see this bug report.

That said, the average person submitting a bug is not going to hunt down the annotated code file to determine who first made a change and then hunt down the code review page to comment on it.
Comment 4 Sumana Harihareswara 2012-01-19 17:46:07 UTC 
Christian, thanks for the patch.  I've added the keywords "need-review" and "patch" so the bug shows up in the lists of patches awaiting review for committing or critique.
Comment 5 Mark A. Hershberger 2012-02-10 20:28:37 UTC 
r111195
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links