Last modified: 2012-04-13 15:19:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28433, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26433 - "Unified diff" not unified (edit_diff)
"Unified diff" not unified (edit_diff)
Status: RESOLVED DUPLICATE of bug 20310
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Spe...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-26 00:37 UTC by Krinkle
Modified: 2012-04-13 15:19 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2010-12-26 00:37:50 UTC
The unified diff field in the details of an abuse filter hit are not unified.
It shows all the previous page text with a "-" in front of it, followed by all the new wikitext (including any and all unchanged lines) with a "+" in front of it.

This causes false positives in filters looking for patterns in the "added_lines" field.

As example:
http://commons.wikimedia.org/wiki/Special:AbuseLog/121696

For those not able to view that hit (due to rights):
It triggered filter 74 which has the following one-liner as "Condition"

   ("{{http://" in lcase(added_lines))


The diff generated by MediaWIki itself in the edit made is as following:

   |Author=[[User:流雨创意工作室|流雨创意工作室]]    |Author=[[User:流雨创意工作室|流雨创意工作室]]
   |Date=2010-11-12    |Date=2010-11-12
-   |Permission={{OTRS pending}}
+   |Permission={{subst:OP}}
   |other_versions=   |other_versions=
   }}  }}

So the only thing changed is a template in the Permissions-field.
AbuseFilter's "edit_diff

@@ -1,14 +1,14 @@
-== Summary ==
-{{Information
-|Description={{zh|1=....!}}
-|Source={{http://foo.bar.com}}
-|Author=[[User:JohnDoe]]
-|Date=2010-11-12
-|Permission={{OTRS pending}}
-|other_versions=
-}}
-
-== Licensing ==
+== Summary ==
+{{Information
+|Description={{zh|1=....!}}
+|Source={{http://foo.bar.com}}
+|Author=[[User:JohnDoe]]
+|Date=2010-11-12
+|Permission={{subst:OP}}
+|other_versions=
+}}
+
+== Licensing ==
(values of the Information-template replaced with samples)


Lines added in edit (AbuseFilter: added_lines)
== Summary ==
{{Information
|Description={{zh|1=....!}}
|Source={{http://foo.bar.com}}
|Author=[[User:JohnDoe]]
|Date=2010-11-12
|Permission={{subst:OP}}
|other_versions=
}}

== Licensing ==


--
Krinkle
Comment 1 Beau 2011-08-20 20:30:58 UTC

*** This bug has been marked as a duplicate of bug 19716 ***
Comment 2 Beau 2012-04-13 15:19:44 UTC

*** This bug has been marked as a duplicate of bug 20310 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links