Last modified: 2010-12-26 04:54:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28425, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26425 - wfTimestamp() fed bogus time value: TYPE=1; VALUE=
wfTimestamp() fed bogus time value: TYPE=1; VALUE=
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-25 11:12 UTC by Niklas Laxström
Modified: 2010-12-26 04:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2010-12-25 11:12:10 UTC 
Some part of the blocking code is feeding false or null into wfTimestamp on every page request.
Comment 1 Bawolff (Brian Wolff) 2010-12-26 00:47:29 UTC 
Was caused by r71751, when the check for if the second argument to wfTimestamp is 0 changed from == to === sign. The constructor to Block has $this->mTimestamp = wfTimestamp( TS_MW, $timestamp ); in it, with $timestamp defaulting to '' if unspecified.

I'm not sure if wfTimestamp should be changed to use == so that '' == 0 or if Block::__construct should be changed to use 0 instead of '', or if both should be done.
Comment 2 Bawolff (Brian Wolff) 2010-12-26 04:54:31 UTC 
fixed in r79013 (I changed the block constructor to use 0 instead of '')
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links