Last modified: 2011-01-08 01:04:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28364, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26364 - tweak AbuseFilter config on hiwiki (rm 1 line)
tweak AbuseFilter config on hiwiki (rm 1 line)
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Highest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-18 19:09 UTC by Mayur
Modified: 2011-01-08 01:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mayur 2010-12-18 19:09:46 UTC
Hi i am a bureaucrat from hi wiki and Due to concern with privacy policy of wikimedia foundation please remove this array from abuse filter exetension as soon as possible
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;
Comment 1 jeremyb 2010-12-18 19:34:55 UTC
The reason for this request is to block crats from viewing IPs in the abusefilter logs.

This looks right per http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/AbuseFilter/SpecialAbuseLog.php?revision=75680&view=markup&pathrev=78330#l278 (comment in the if block is "Private stuff, like IPs.")
Comment 2 Antoine "hashar" Musso (WMF) 2010-12-18 19:43:55 UTC
Should be good now:


--- abusefilter.php	(revision 1369)
+++ abusefilter.php	(working copy)
@@ -72,7 +72,7 @@
 	$wgGroupPermissions['abusefilter']['abusefilter-modify'] = true;
 	$wgGroupPermissions['bureaucrat']['abusefilter-modify-restricted'] = true;
 	$wgGroupPermissions['bureaucrat']['abusefilter-revert'] = true;
-	$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;
+	$wgGroupPermissions['bureaucrat']['abusefilter-private'] = false;
 	$wgGroupPermissions['sysop']['abusefilter-revert'] = true;
 	$wgGroupPermissions['sysop']['abusefilter-modify'] = false;
 	$wgGroupPermissions['*']['abusefilter-log-detail'] = true;
Comment 3 Mayur 2010-12-18 19:50:41 UTC
No this is not disabled so far, it is still showing that right in special:user group rights and abuse log we are able to see ips
Comment 4 Mayur 2010-12-18 19:52:57 UTC
it will better to remove this array-
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;

rather than setting it to false value
Comment 5 Mayur 2010-12-18 19:58:20 UTC
you have instered this array two times
see above-

$wgGroupPermissions['bureaucrat']['abusefilter-private'] = true;
$wgGroupPermissions['bureaucrat']['abusefilter-private'] = false;

one time for true and one time for false, that why it is not working, remove one array and set one to false, or remove both array
Comment 6 Antoine "hashar" Musso (WMF) 2010-12-18 20:08:44 UTC
I have synced the wrong file. The change is now live!

I have checked:
http://hi.wikipedia.org/w/index.php?title=Special:ListGroupRights&uselang=en
Comment 7 Mayur 2010-12-18 20:33:05 UTC
As this bug has been fixed, i am closing this bug.Thanking you very much for a quick respose to this emergency bug
Comment 8 Antoine "hashar" Musso (WMF) 2010-12-18 21:20:32 UTC
You are welcome :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links