Last modified: 2011-03-13 18:06:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28351, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26351 - Assign id="file" to image data cell in file history table
Assign id="file" to image data cell in file history table
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.17.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-16 13:09 UTC by Erwin Dokter
Modified: 2011-03-13 18:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Erwin Dokter 2010-12-16 13:09:50 UTC 
(File: ImagePage.php, line 979)

Please assign id="file" to the <td> for the thumbnail in the file history table. This will enable the application of a checkered background for the image in CSS.
Comment 1 Bryan Tong Minh 2010-12-16 13:18:12 UTC 
We can't do that, as ids are required to be unique. We can however add a CSS class.
Comment 2 Erwin Dokter 2010-12-16 13:20:19 UTC 
How do you mean unique? Galleries has all image divs with id="file". Why can't it be done here?
Comment 3 Bryan Tong Minh 2010-12-16 13:25:42 UTC 
A certain id is only allowed to to occur once on a page per the HTML specification. Galleries do not have divs with the same id.
Comment 4 Bryan Tong Minh 2010-12-16 13:27:25 UTC 
On second thought, we don't even need to introduce a new class, as images in the filehistory can be styled with ".filehistory a img"
Comment 5 Erwin Dokter 2010-12-16 13:29:40 UTC 
I guess that works. Thanks.
Comment 6 Erwin Dokter 2010-12-16 13:30:07 UTC 
Oops, please close again... it automatically reopened.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links