Last modified: 2011-01-11 01:57:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28346, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26346 - Audio player overflowing
Audio player overflowing
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Michael Dale
http://fr.wiktionary.org/wiki/Wiktion...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-15 22:09 UTC by JackPotte
Modified: 2011-01-11 01:57 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
compared player layouts of mwEmbed (41.10 KB, image/png)
2010-12-22 15:36 UTC, Michael Dale
Details

Description JackPotte 2010-12-15 22:09:16 UTC
Hello,
Our audio player is hiding some informations for a few weeks, for example the IPA into http://fr.wiktionary.org/wiki/armure#Prononciation.
Comment 1 JackPotte 2010-12-15 22:20:26 UTC
Apparently, it comes from the mwEmbed JS.
Comment 2 JackPotte 2010-12-22 07:04:32 UTC
As you didn't answer I removed mwEmbed from Common.js (to put it into [[MediaWiki:Gadget-mwEmbed.js]]).
Comment 3 Michael Dale 2010-12-22 15:36:55 UTC
Created attachment 7921 [details]
compared player layouts of mwEmbed
Comment 4 Michael Dale 2010-12-22 18:52:24 UTC
That's strange I did not get this bug in my email until now :(  The player is set to "relative" layout so that some elements inside can be properly positioned. I can set the parent container to the "inline" if we want it to match the oggHandler layout. Would that fix what your issue is? or is it doing something else in your browser?
Comment 5 JackPotte 2010-12-22 20:28:16 UTC
Maybe... Currently it persists.
Comment 6 Michael Dale 2010-12-22 20:42:17 UTC
doe the attached screen shot match your browser layout? Is that the issue your running into ?
Comment 7 JackPotte 2010-12-22 20:55:18 UTC
My Firefox doesn't display the last millimeter or [yn‿aʁ.myʁ], so "‿" is totally invisible. Moreover, it can be worst for some others as the community insisted to remove it from the Common.js ASAP.
Comment 8 Michael Dale 2010-12-24 21:52:56 UTC
Should be fixed in r78977 ( will match oggHandler layout ) Will deploy this shortly.
Comment 9 JackPotte 2011-01-08 18:33:50 UTC
It's still in error:
http://fr.wiktionary.org/wiki/armure#Prononciation
Comment 10 Michael Dale 2011-01-09 17:28:27 UTC
Sorry I had not deployed the update yet ( a bunch of other updates got warped into this mwEmbed deployment, will do a blog post with full update info. ) 

If you view the console it should say "mwEmbed:remote: r183" or greater. ( once I deploy ) 

I will make a note on this bug once the deployment goes out.
Comment 11 Michael Dale 2011-01-09 22:31:19 UTC
update has gone out, once you shift refresh gadget should read "mwEmbed remote: r183" and should display properly...

but it appears http://fr.wiktionary.org/w/index.php?title=MediaWiki:Common.css has setup some style overrides. These don't work on "buttons" but do limit the mwEmbed based player just to the play button. This of course a bad idea, since it will apply to videos as well! ... if you want just the audio play button interface we could wrap the players in a specific class or set their width in the template ( mwEmbed should obey size requests)  

but in the mean time I recommend removing those css rules in Common.css
Comment 12 JackPotte 2011-01-11 01:57:44 UTC
I advised the community of this comment on the initial bug report: http://fr.wiktionary.org/wiki/Wiktionnaire:Wikid%C3%A9mie/d%C3%A9cembre_2010#lecteur_audio.

But if no other answer is left, I will study to propose a more recent discussion soon.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links