Last modified: 2012-04-12 13:53:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28305, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26305 - Javascript fallback 'href' for Watch-link / Watch-star isnt updated when page is (un)watched via javascript
Javascript fallback 'href' for Watch-link / Watch-star isnt updated when page...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-11 20:41 UTC by Krinkle
Modified: 2012-04-12 13:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2010-12-11 20:41:53 UTC
When javascript is enabled and one clicks the Watch-link or Watch-star the href-attribute of the anchor-tag isnt updated from action=watch to action=unwatch.
Comment 1 Krinkle 2010-12-11 20:43:57 UTC
Although it's not a very common usecase that javascript support would fail after the page has been watched or unwatched with javascript, this was intented to be supported in skins/common/ajaxwatch.js by the following line:
<pre>

-			$link.attr( 'href', $link.attr( 'href' ).replace( '/&action=' + action + '/', '&action=' + otheraction ) );

</pre>
However.. I guess this is a left-over from a regex or something becuase that doesn't do anything. Those slashes are within the single-quotes and, since those arent in the link, match nothing.
Comment 2 Krinkle 2010-12-11 20:45:21 UTC
Fixed in r78150
Comment 3 Krinkle 2010-12-11 20:46:21 UTC
Changing version to 1.16.0, confirmed in that version as well.
Perhaps backport this one to 1.17 (perhaps also to 1.16)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links