Last modified: 2012-08-31 16:21:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28303, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26303 - WikiEditor toc module: textarea not hidden on ProofreadPage pages
WikiEditor toc module: textarea not hidden on ProofreadPage pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Zaran
http://spiele.j-crew.de/w/index.php?t...
:
Depends on:
Blocks: Wikisource
  Show dependency treegraph
 
Reported: 2010-12-11 08:38 UTC by Thomas Bleher
Modified: 2012-08-31 16:21 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Picture showing the bug (107.22 KB, image/png)
2010-12-11 08:38 UTC, Thomas Bleher
Details

Description Thomas Bleher 2010-12-11 08:38:34 UTC
Created attachment 7903 [details]
Picture showing the bug

When the toc module from the WikiEditor extension is active, the textarea (wpTextArea1) on ProofreadPage pages is not properly hidden, leading to double text display (see the URL and the attached screenshot). When deactivating the toc module in the preferences, the textarea is properly hidden, and everything looks fine.

Loading and saving of pages work fine, it just looks quite strange.
This is on current SVN trunk and happens with IceWeasel 3.5.15 and Chromium 6.0.472.63~r59945-2.
Comment 1 Mark A. Hershberger 2011-01-31 19:45:14 UTC
Is this still happening?
Comment 2 Thomas Bleher 2011-01-31 22:07:11 UTC
On r80818, together with up-to-date ProofreadPage (r81155) and WikiEditor (r 81165) extension, the page looks exactly the same as in the screenshot.

I tried to test with newer phase3, but when using r81272, the WikiEditor toolbar doesn't show up at all! I haven't had time to track this down yet.

So yes, as far as I can tell the problem is still there.
Comment 3 Bawolff (Brian Wolff) 2011-02-01 22:26:16 UTC
Appears to be proofreadPage's fault when it removes the wpTextbox1 and then replaces it with its own version, that doesn't have the relevant styes (see proofreadpage.js)

Changing component to proofreadpage
Comment 4 Thomas Bleher 2011-10-03 11:14:06 UTC
FWIW, this still happens in current MediaWiki (r98745), with up-to-date ProofreadPage (r98583) and WikiEditor (r98463).
Comment 5 Sumana Harihareswara 2012-06-07 19:11:10 UTC
Is this still happening, with the version of the code now on Wikimedia sites?
Comment 6 Beau 2012-06-11 18:43:10 UTC
Yes, it still reproducible. As far as I know this function of Wikieditor is experimental and is not available on Wikimedia sites yet.
Comment 7 Tpt 2012-08-31 16:21:48 UTC
This bug looks like fixed with the rewriting of the Javascript code that insert tthe image : https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ProofreadPage.git;a=commit;h=5912c329259b02404062f7d2469672307da083ca

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links