Last modified: 2011-02-14 03:10:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28298, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26298 - Long article emptied when edited
Long article emptied when edited
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-10 15:51 UTC by Marko Lindqvist
Modified: 2011-02-14 03:10 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marko Lindqvist 2010-12-10 15:51:05 UTC
User told me that she had been adding stuff to already long article. When she saved her changes, whole article was emptied.

This warning I, as server admin, got to my email is probably related:
suhosin[443]: ALERT - configured request variable
value length limit exceeded - dropped variable 'wpTextbox1' ... wiki/index.php

While user agreed that article was overlong and should have been divided to several separate articles, completely losing her edits and even emptying existing article is not what should have happened.
Comment 1 Ilmari Karonen 2010-12-10 16:05:25 UTC
This looks more like a misfeature in suhosin than a MediaWiki bug, but we probably could be more careful about not treating a missing wpTextbox1 field as empty.
Comment 2 Brion Vibber 2011-02-14 03:10:24 UTC
To resolve this, edit your php.ini and raise the limits in suhosin.request.max_value_length and suhosin.post.max_value_length settings to more reasonable values.

As a helper for users hit by this, I've made a tweak on trunk in r82102 to check for the case of a missing wpTextbox1 field (which I can confirm when installing Suhosin and setting the suhosin.request.max_value_length absurdly low). This extends the previous behavior to check for incomplete form submissions by just checking if the edittime (a late field) is present; and also I added a message to show when it forces those previews.

So now when someone hits this sort of filter, it'll force a preview. Unfortunately that'll show a big empty box, but at least you'll know it's because something went wrong, and it won't save it silently.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links