Last modified: 2012-11-27 09:06:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28280, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26280 - All files should have the GPL header (unless explicitally licensed differently)
All files should have the GPL header (unless explicitally licensed differently)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-08 12:25 UTC by Sam Reed (reedy)
Modified: 2012-11-27 09:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2010-12-08 12:25:49 UTC 
All files should have the GPL header (unless explicitally licensed differently)
Comment 1 Antoine "hashar" Musso (WMF) 2012-11-18 14:38:35 UTC 
Catched a few of them with https://gerrit.wikimedia.org/r/33981
Comment 2 db [inactive,noenotif] 2012-11-24 21:18:12 UTC 
(In reply to comment #1)
> Catched a few of them with https://gerrit.wikimedia.org/r/33981

Status Merged
Comment 3 Antoine "hashar" Musso (WMF) 2012-11-26 18:50:20 UTC 
I am not sure how we could enforce that in mediawiki/core.git . Maybe make sure that whenever a PHP file is added in the repository, it matches the string "This program is free software".
Comment 4 Sam Reed (reedy) 2012-11-26 19:19:49 UTC 
(In reply to comment #3)
> I am not sure how we could enforce that in mediawiki/core.git . Maybe make sure
> that whenever a PHP file is added in the repository, it matches the string
> "This program is free software".

Do we really need to?

If we get all files currently in the repo "fixed", then just be vigilant to any new ones added
Comment 5 Bartosz Dziewoński 2012-11-27 06:00:46 UTC 
Resolving as fixed, since I214a988e was merged.

(Unless we want to make this a jenkins task that would check all files for the header or something, but do we?)
Comment 6 Antoine "hashar" Musso (WMF) 2012-11-27 09:06:19 UTC 
I opened bug 42472 to add a lint check in Jenkins to make sure a new file contains the GPL header. That will avoid us having to remember about it or someone to reopen this bug :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links