Last modified: 2011-02-08 21:56:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28267, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26267 - Pressing enter submits as Cancel/Back instead of Continue
Pressing enter submits as Cancel/Back instead of Continue
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-06 13:18 UTC by Krinkle
Modified: 2011-02-08 21:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2010-12-06 13:18:36 UTC
Atleast in WebKit browsers during the installation with the new installer as of 1.17-svn pressing Enter in any form element brings me back to the previous step.

Visually it makes sense for the Back-button to be on the left hand side, unfortunately browsers by default submit to the closest input[type=submit] button.

I see in the source code a way to prevent this, namely a hidden duplicate of the Continue-button before the Back-button (hidden as in, style="display:none").

However, as smart as browsers are, pressing Enter doesn't submit to the next submitting element, but to the next 'visible' submitting element.

We need to either put the continue button to the left for real, and drop the hidden-duplicate thing.
Or find a way to visually hide that duplicate button while still fooling browsers it's there.
Comment 1 Krinkle 2010-12-06 13:20:35 UTC
I've done the latter in r77123. 

It now no longer applies inline styling display:none but "visibility:hidden;overflow:hidden;width:1px;margin:0".

the visibility hides it visually, but still keeps the box model. So for that reason the width has been forced to a single pixel and overflow to hidden.
And becuase of CSS rules applying to the submit buttons in the Installer the magin has been reset to 0 as well.

This has been tested in WebKit browsers (Safari 5 on Mac, Chrome 2 on Windows)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links