Last modified: 2014-11-18 18:07:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26256 - Accept and reject buttons are too similar
Accept and reject buttons are too similar
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 26335
  Show dependency treegraph
 
Reported: 2010-12-05 22:24 UTC by Tisza Gergő
Modified: 2014-11-18 18:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2010-12-05 22:24:17 UTC
The new reject button that shows up for reviewers is too easy to confuse with the accept button (especially when one is patrolling a lot of revisions in a short time). There should be an obvious visual clue to tell them apart, like green/red color.
Comment 1 Aaron Schulz 2010-12-05 23:36:51 UTC
I had a coloring scheme, but it was removed (but not replaced with anything).
Comment 2 Rob Lanphier 2010-12-06 07:49:27 UTC
We did intend to replace it with something (e.g. icons on the buttons), but didn't have time for the proper solution.  I felt pretty strongly that the current all-black, all-the-time button text was better than the button scheme, which I think Brandon concurred with me on (though I'm not positive I checked wiht him).  Anyway, it's good we have an issue logged to make sure we do this right.  Assigning to Brandon for a quick mockup when he gets the chance.
Comment 3 Brandon Harris 2010-12-06 18:10:54 UTC
The reject button shouldn't be a button if we can avoid it.  It should just be a text link.
Comment 4 Max Semenik 2010-12-06 19:38:28 UTC
(In reply to comment #3)
> The reject button shouldn't be a button if we can avoid it.  It should just be
> a text link.

Then accept shouldn't be a button too for consistency.
Comment 5 Brandon Harris 2010-12-06 19:40:48 UTC
Not necessarily.  

To be honest, the entire accept/reject/unaccept interface should have a totally different UI.  But the resources to make it so aren't there right now (and won't be committed unless we have further sign off).  

I suppose the question really is this:  "is it possible to undo a 'reject'" and if the answer is no or 'yes but very difficult or tedious' then we should downplay reject.  We know we can always revert an accept.
Comment 6 Tisza Gergő 2010-12-06 21:17:57 UTC
(In reply to comment #5)
> I suppose the question really is this:  "is it possible to undo a 'reject'" and
> if the answer is no or 'yes but very difficult or tedious' then we should
> downplay reject.  We know we can always revert an accept.

It is difficult (and pollutes page history), but as long as you need two clicks for the reject, that isn't much of a problem. Mistaking the options (or even just having to think about which one to choose) wastes patrollers' time, though.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links