Last modified: 2010-12-20 22:48:07 UTC
Please, put some semicolons in the file FlaggedRevs/client/flaggedrevs.js to the following places, after the closing curly brackets: lines - 163 - 179 - 222 - 229 - 231 - 237 Thank you!
And to the review.js also :) Affected lines: - 63 - 76 - 94 - 312
I haven't heard of any browsers having problems with this. But it should be done anyway.
(In reply to comment #2) > I haven't heard of any browsers having problems with this. But it should be > done anyway. Done in r77844,r77845.
Thank you! I'm combining all of the JS files MediaWiki uses into a big one, and Firefox showed some warnings that semicolons are missing.
(In reply to comment #2) > I haven't heard of any browsers having problems with this. But it should be > done anyway. One thing is it's cleaner to end a statement with a semicolon, although not strictly required. If the last statement in a file doesn't end with a semicolon, concatenating files can result in strange bugs. Declarations like function foo( args ) { code } don't need a semicolon, but things like var foo = function( args ) { code }; do, because they're statements (assignments).
