Last modified: 2010-12-04 22:46:57 UTC
In my understanding, the reject button should only be shown when viewing the diff between the latest and the last stable version and should reset the page to the stable version. But when there are more than one pending changes like this: * (unstable) Edit 2 * (unstable) Edit 1 * Stable Version And one is viewing the diff between Stable and Edit 1, the Reject button is still shown. The summary says, that only Edit 1 will be revoked, but after undoing, the second edit is also undone, and the new version is unstable. The problem with this is, that to the user there is no hint, that they reject more revisions then viewing. See http://de.labs.wikimedia.org/w/index.php?title=Testseite_f%C3%BCr_Bugreport&action=history for a testcase. The summary of the last edit says: "The first edit of Steef389 [...] was rejected."
I'm can't reproducing this on my test wiki.
(In reply to comment #1) > I'm can't reproducing this on my test wiki. OK, I can use /depl MW core. I think I know specifically what this might be...
(In reply to comment #2) > (In reply to comment #1) > > I'm can't reproducing this on my test wiki. > > OK, I can use /depl MW core. I think I know specifically what this might be... I meant "on", not "use". Anyway, it was what I figured: an assanine $GET['oldid'] dependency in the getUndoText() function. This was fixed a while back in r72846, but was not pushed into production. I've just merged and synced it.
