Last modified: 2011-01-26 19:15:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26235 - Wrong number of total revisions displayed at top of the list view
Wrong number of total revisions displayed at top of the list view
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-04 18:51 UTC by Sam Reed (reedy)
Modified: 2011-01-26 19:15 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for quick sanity check (1.31 KB, patch)
2011-01-26 18:44 UTC, Sam Reed (reedy)
Details

Description Sam Reed (reedy) 2010-12-04 18:51:56 UTC
On my test wiki, MW repo, one revision tagged as "lol", and only one returned, but it says "Total number of results: 77,378"
Comment 1 Sam Reed (reedy) 2010-12-05 19:40:46 UTC
Above is Wrong number of total revisions when filtered by tag


Seemingly occurs in more states...


http://www.mediawiki.org/wiki/Special:Code/MediaWiki/status/fixme?author=platonides
Comment 2 Brion Vibber 2011-01-24 04:28:49 UTC
Looks like some of the list view classes need to override either getSpecializedWhereClause, or the entire getRevCount method...

... or better yet, replace getRevCount() by calling into the pager and turning its query into a count(*) without the offset/limit. That would avoid having to duplicate the query code that's already in the SvnRevTablePager subclasses.
Comment 3 Sam Reed (reedy) 2011-01-24 07:11:41 UTC
Might see if I can get chance to poke at this sometime this week...
Comment 4 Sam Reed (reedy) 2011-01-26 18:44:53 UTC
Created attachment 8046 [details]
Patch for quick sanity check
Comment 5 Sam Reed (reedy) 2011-01-26 19:15:20 UTC
r81046

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links