Last modified: 2012-05-27 23:03:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28233, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26233 - thumbnail generator fails with a % in file name (update image magik)
thumbnail generator fails with a % in file name (update image magik)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://upload.wikimedia.org/wikipedia...
: ops, testme, upstream
: 30789 31079 31092 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-04 15:32 UTC by Bergi
Modified: 2012-05-27 23:03 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bergi 2010-12-04 15:32:45 UTC
The error report says something about "unable to open image". Imho the % isn't escaped correctly somewhere, could this be fixed please? 
I think this error occurs just at jpgs, compare [[commons:file:00%.svg]], [[commons:file:00%.png]].
Comment 1 Derk-Jan Hartman 2010-12-04 22:13:28 UTC
Where are you getting these links from ? If I visit these image pages, all links to their thumbs are correct.
Comment 2 Bawolff (Brian Wolff) 2010-12-04 22:32:04 UTC
http://upload.wikimedia.org/wikipedia/commons/thumb/3/30/Mundloch_wiki_20%25.JPG/120px-Mundloch_wiki_20%25.JPG is broken for me, and thats directly from the history section of [[commons:file:Mundloch_wiki_20%25.JPG]] (the image is small, so the main image displayed on the image description is not resized).

p.s. correct links for the above mentioned counter-examples are: [[commons:file:00%25.svg]] and [[commons:file:00%25.png]] (since bugzilla isn't as tolerant as wikitext)
Comment 3 Bryan Tong Minh 2010-12-12 15:32:32 UTC
cc. Tim Starling; he examined the IM source for r65467, so hopefully he has an idea what is going on.
Comment 4 Tim Starling 2011-01-10 02:25:38 UTC
Is there any test case which has not been destroyed by Commons admins?
Comment 6 Tim Starling 2011-01-10 12:45:28 UTC
There's a bug which causes %% to not work as expected. I've reported it upstream, with a patch:

http://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=17810
Comment 7 Dan Collins 2011-07-09 20:12:00 UTC
Since the upstream claims that a release was in 6.6.7-1, and the current version is 6.7.0-8, I can only assume that your patch was applied. I can't tell what version we're running though, and the bug still seems to be present, so tagging this testme.
Comment 8 Bawolff (Brian Wolff) 2011-07-09 22:04:16 UTC
Point of note in response to comment 0, this also applies to png images in addition to jpg images. The reason 00%.png works is because the image is already tiny and we don't upscale really small images. (SVG's aren't affected since we don't use image magick for them)

I believe we're currently using ImageMagick 6.6.2-6 2011-03-09 Q8 (based on image metadata), which would indicate we need to update to fix this bug. Thus I'm going to remove testme and add ops.
Comment 9 Jelle Zijlstra 2011-09-07 04:10:16 UTC
*** Bug 30789 has been marked as a duplicate of this bug. ***
Comment 10 Brion Vibber 2011-09-07 20:04:34 UTC
Copying from the dupe on bug 30789:

I can confirm that the patch made it in and that 6.6.9 works for me locally; we still have 6.6.2 deployed however, so it's still affecting us in production.

I've filed an RT ticket internally to request that our deployed ImageMagick get
updated: http://rt.wikimedia.org/Ticket/Display.html?id=1444
Comment 11 Bawolff (Brian Wolff) 2011-09-22 12:44:23 UTC
*** Bug 31092 has been marked as a duplicate of this bug. ***
Comment 12 Mark A. Hershberger 2011-09-22 17:49:29 UTC
*** Bug 31079 has been marked as a duplicate of this bug. ***
Comment 13 Rainer Rillke @commons.wikimedia 2011-12-09 22:35:49 UTC
Just another example. I just report it because the last entry is from 09-2011, about 3 months ago.

https://commons.wikimedia.org/wiki/File:%25_of_U.S._households_connected_by_age.png
Comment 14 Bawolff (Brian Wolff) 2012-02-28 02:07:02 UTC
Umm, is this still happening? None of the example images in the bug seem to be affected (However, the metadata seems to still indicate the old version of imagemagick in use...)
Comment 15 Jelle Zijlstra 2012-02-28 13:14:04 UTC
Thumbnails in the history of https://en.wikipedia.org/wiki/File:Ex_1%25_ample.jpg still don't show up. See the error at https://upload.wikimedia.org/wikipedia/en/thumb/d/db/Ex_1%25_ample.jpg/111px-Ex_1%25_ample.jpg .
Comment 16 Bawolff (Brian Wolff) 2012-02-28 15:44:17 UTC
(In reply to comment #15)
> Thumbnails in the history of
> https://en.wikipedia.org/wiki/File:Ex_1%25_ample.jpg still don't show up. See
> the error at
> https://upload.wikimedia.org/wikipedia/en/thumb/d/db/Ex_1%25_ample.jpg/111px-Ex_1%25_ample.jpg
> .

Hmm, enwikipedia is still on 1.18, so maybe this magically got fixed somehow in 1.19. Uploading the image to test, and it seems to work https://test.wikipedia.org/wiki/File:Ex_1%25_ample.jpg
Comment 17 Antoine "hashar" Musso (WMF) 2012-05-27 23:03:40 UTC
Looks like that issue got solved, both [[commons:file:00%.svg]], [[commons:file:00%.png]] give thumbnails.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links