Last modified: 2011-11-10 07:09:08 UTC
A lot with similar purpose etc, 3 external Store... Be nice to clear it up a bit
For MZMcBrides benefit, initial summary: "There are too many files in the root of phase3/includes"
A snapshot of the directory contents right now: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/?pathrev=77679 A "conf" subdirectory could hold DefaultSettings.php, tidy.conf, SiteConfiguration.php and likely some other files. A "profile" subdirectory seems like it could hold some files as well. That said, no decent justification has been given (yet) for moving anything around, other than it would "be nice."
Profile as in Profiler? That's a no go. It seems there are some weird explicit dependencies from maintenance and others. I tried to move that before and all hell broke loose
(In reply to comment #3) > Profile as in Profiler? > > That's a no go. It seems there are some weird explicit dependencies from > maintenance and others. I tried to move that before and all hell broke loose Yes, I was referring to Profiler.php, ProfilerSimple.php, ProfilerSimpleText.php, ProfilerSimpleTrace.php, ProfilerSimpleUDP.php, and ProfilerStub.php.
(In reply to comment #3) > Profile as in Profiler? > > That's a no go. It seems there are some weird explicit dependencies from > maintenance and others. I tried to move that before and all hell broke loose Because our batshit profiler instructions require you to require Profiler.php, which is stupid. We'd have to leave an alias in place for back-compat, which would render the move pointless. Some of the profiler helper stuff may be movable.
(In reply to comment #5) > > Because our batshit profiler instructions require you to require Profiler.php, > which is stupid. We'd have to leave an alias in place for back-compat, which > would render the move pointless. > > Some of the profiler helper stuff may be movable. Couldn't we just do this, and "deprecate" it under the normal ways... ie just leave for 1.17, 1.18 mark wfDeprecated... Not brilliant, but a step in the right direction Also, the instructions suck - "Modify the StartProfiler.php". Which StartProfiler.php? A quick look at the code says it needs to be in the root. But who knew? I guess http://www.mediawiki.org/w/index.php?title=StartProfiler.php&action=edit&redlink=1 should be created
We'd also possibly need to leave ProfilerStub.php/an includes/alias file Just incase anyone has a base StartProfiler.php that includes ProfilerStub.php for some daft reason Seeing as that duplicates methods from Profiler.... With the alias files, 6 can be moved, leaving 2 "deprecated" redirects...
Created attachment 7887 [details] Patch to do all of the moving...
Created attachment 7888 [details] Really move profiler
Comment on attachment 7888 [details] Really move profiler Not worth the effort (at all) with Profiler stuff.
I reorganized the profiler in r86175 and followups.
Is there anything else to get moved or can we just close this bug? I am not sure there is any point in keeping it around.
(In reply to comment #12) > Is there anything else to get moved or can we just close this bug? I am not > sure there is any point in keeping it around. I think we can go ahead and close this.
