Last modified: 2012-11-08 14:30:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28201, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26201 - ContactPage Extension: Bugfix Remember Checkbox Value
ContactPage Extension: Bugfix Remember Checkbox Value
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ContactPage (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-02 12:36 UTC by Christoph Mitasch
Modified: 2012-11-08 14:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christoph Mitasch 2010-12-02 12:36:07 UTC
Hello,

I just tried out the ContactPage Extension and fixed one bug:

SpecialContact.php:
235c241
< 					Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .
---
> 					Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) .

The problem is that if the form is filled out and a value es empty, the checkbox value is not remembered when the form is showed a second time.

The Value "ccmeonemails" does only exist in this part of the code and nowhere else, so the value can never have an value.

Please push the patch forward!

Thank you,
Christoph
Comment 1 Roan Kattouw 2010-12-02 14:16:12 UTC
(In reply to comment #0)
> SpecialContact.php:
> 235c241
> <                     Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe',
> 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) .
> ---
> > 					Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) .
> 
This patch was trivial and very easy to apply by hand, but in the future please attach your patches as files and use unified diff format ("diff -u" or "svn diff").

> Please push the patch forward!
> 
Thanks for the patch! Applied in r77577.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links