Last modified: 2012-11-08 14:30:24 UTC
Hello, I just tried out the ContactPage Extension and fixed one bug: SpecialContact.php: 235c241 < Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) . --- > Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) . The problem is that if the form is filled out and a value es empty, the checkbox value is not remembered when the form is showed a second time. The Value "ccmeonemails" does only exist in this part of the code and nowhere else, so the value can never have an value. Please push the patch forward! Thank you, Christoph
(In reply to comment #0) > SpecialContact.php: > 235c241 > < Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', > 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) . > --- > > Xml::checkLabel( wfMsg( 'emailccme' ), 'wpCCMe', 'wpCCMe', $this->cc_me ) . > This patch was trivial and very easy to apply by hand, but in the future please attach your patches as files and use unified diff format ("diff -u" or "svn diff"). > Please push the patch forward! > Thanks for the patch! Applied in r77577.