Last modified: 2011-05-22 15:12:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28195, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26195 - Filtering by author, then by path, gets an overly long query string, with duplicate parameters
Filtering by author, then by path, gets an overly long query string, with dup...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 26240
  Show dependency treegraph
 
Reported: 2010-12-01 23:59 UTC by Sam Reed (reedy)
Modified: 2011-05-22 15:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-12-01 23:59:31 UTC
Special:Code/MediaWiki/author/reedy

Filter by "/trunk/extensions/CodeReview/"

And we end up at
index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki&limit=50&title=Special:Code/MediaWiki/author/reedy

It works, but we've got 2 titles

Clicking again on the go button to filter by path, we then get

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki&limit=50&path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/author/reedy
Comment 1 Sam Reed (reedy) 2010-12-02 00:09:21 UTC
Filtering by path twice does the same..

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/path&limit=50&title=Special:Code/MediaWiki

index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki/path&limit=50&path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki

For the one above, clicking back onto the filtered author again, goes back to the first..
Comment 2 Sam Reed (reedy) 2010-12-02 00:25:06 UTC
I should say that this is on trunk, 1.16wmf4 seems fine...
Comment 3 Krinkle 2010-12-02 03:21:14 UTC
Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new variable to the current address.
That would explain the difference why bug 26141 is fixed in trunk but also the long urls

Can't find an svn revision to proof this though.
Comment 4 Roan Kattouw 2010-12-02 14:04:59 UTC
(In reply to comment #3)
> Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
> variable to the current address.
You should build the query string in an array and use wfArrayToCGI().
Comment 5 Sam Reed (reedy) 2010-12-02 16:54:13 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
> > variable to the current address.
> You should build the query string in an array and use wfArrayToCGI().

That sounds like one way of saying we need to revamp the whole way that CR does parameters.

Rather than:
Special:Code/repo/author/authorname
Special:Code/repo/path/path/to/somewhere

etc, do them all as &parameter=value
Comment 6 Roan Kattouw 2010-12-02 17:09:58 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Perhaps trunk (coincidently?) fixed bug 26141 by dirty appending the new
> > > variable to the current address.
> > You should build the query string in an array and use wfArrayToCGI().
> 
> That sounds like one way of saying we need to revamp the whole way that CR does
> parameters.
> 
> Rather than:
> Special:Code/repo/author/authorname
> Special:Code/repo/path/path/to/somewhere
> 
> etc, do them all as &parameter=value
The form should submit them that way, but I like being able to do /repo/author/catrope .
Comment 7 Sam Reed (reedy) 2011-05-21 22:51:21 UTC
Fixed in backlog, ie r88550 I guess...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links