Last modified: 2010-12-31 20:39:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28194, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26194 - WikiEditor + Liquidthreads: addModules is called once for each comment, increasing page load times drastically
WikiEditor + Liquidthreads: addModules is called once for each comment, incre...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-01 22:54 UTC by Nikola Kovacs
Modified: 2010-12-31 20:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
run addmodules only once (1.02 KB, patch)
2010-12-01 22:54 UTC, Nikola Kovacs 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Nikola Kovacs 2010-12-01 22:54:01 UTC 
Created attachment 7883 [details]
run addmodules only once

Liquidthreads calls EditPage::getEditToolbar a lot of times (once for each comment, if I'm not mistaken), each time WikiEditorHooks::addModules runs, and the result is a huge number of calls to wfMsgReal (over 20000 with a decent sized lqt talk page), and a drastic increase in page load times. The page will also contain all the messages multiple times, increasing its size. I've attached a patch to only run addModules once - I'm not sure this is the correct way to fix the problem, but addModules shouldn't be adding the same messages over and over again if it gets called multiple times.
Comment 1 Roan Kattouw 2010-12-02 14:03:07 UTC 
What is this patch against? The relevant code does not appear in trunk; in fact, this is already fixed in trunk thanks to ResourceLoader.
Comment 2 Nikola Kovacs 2010-12-02 16:55:39 UTC 
The UsabilityInitiative extension in 1.16wmf4.
Comment 3 Roan Kattouw 2010-12-31 20:39:40 UTC 
Deployed your patch, thanks.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links