Last modified: 2010-12-01 02:23:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28174, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26174 - mwsuggest invalid syntax
mwsuggest invalid syntax
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-30 18:25 UTC by Sam Reed (reedy)
Modified: 2010-12-01 02:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-11-30 18:25:16 UTC
if( r == null ) {
		return; // not our event
	}

Shouldn't it be returning true/false?
Comment 1 Derk-Jan Hartman 2010-11-30 20:06:18 UTC
not really. Javascript is not that ordered. It shouldn't return false (which would end bubbling), but other than that, I don't think there are any return value restrictions on eventhandlers.
Comment 2 Roan Kattouw 2010-11-30 20:07:58 UTC
Also note that not returning a value in Javascript implicitly means returning null.
Comment 3 Sam Reed (reedy) 2010-11-30 20:13:03 UTC
"Return value of type prevents selection is required" is the error the IDE is whinging about. I've no idea what it means

Will revert back when I get some clarification

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links