Last modified: 2012-04-16 09:16:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28169, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26169 - ApiUploadTest is flaky -- inconsistent results
ApiUploadTest is flaky -- inconsistent results
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-30 05:29 UTC by Neil Kandalgaonkar
Modified: 2012-04-16 09:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Neil Kandalgaonkar 2010-11-30 05:29:18 UTC 
multiple runs of ApiUploadTest have different results. Sometimes they succeed, sometimes fail.

Oddly, printing debug information seems to make the errors more elusive.

Arguably ApiUploadTest is done wrong; it should open up a real HTTP connection rather than elaborately simulating an API request.
Comment 1 Chad H. 2010-11-30 18:07:40 UTC 
Is this actually in wikimedia-deployment, or on trunk?

I wouldn't trust any of the unit tests to run on deployment, lots of unmerged changes there.
Comment 2 Mark A. Hershberger 2011-01-29 18:12:24 UTC 
the purpose of ApiUploadTest is not to test the actual upload so much as the code path handling the API upload.  Requiring the test to use an actual web server would mean the tests couldn't be used by as many people.
Comment 3 Rob Lanphier 2012-02-02 00:32:47 UTC 
Is this still an issue?
Comment 5 Rob Lanphier 2012-02-06 21:28:17 UTC 
Antoine is going to remove this test from the default group of tests.  I'm unassigning this from him for now.  Whoever takes this on probably needs to set up mock objects and other mechanisms to avoid this unreliability in testing.
Comment 6 Antoine "hashar" Musso (WMF) 2012-02-06 21:40:14 UTC 
Disabled with r110790
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links