Last modified: 2011-02-08 21:56:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26141 - Submitting path on Author-filter page 'forgets' the author
Submitting path on Author-filter page 'forgets' the author
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-27 13:28 UTC by Krinkle
Modified: 2011-02-08 21:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2010-11-27 13:28:28 UTC
When on :
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/author/krinkle
and typing in the path-field:
/trunk/phase3/includes/installer/

One would expect to end up on:
http://www.mediawiki.org/w/index.php?title=Special%3ACode%2FMediaWiki%2Fauthor%2Fkrinkle&path=%2Ftrunk%2Fphase3%2Fincludes%2Finstaller%2F

(author is still 'krinkle', path is now filtered as well)

However, pressing "Go" brings us to:
http://www.mediawiki.org/w/index.php?path=%2Ftrunk%2Fphase3%2Fincludes%2Finstaller%2F&title=Special%3ACode%2FMediaWiki

The author-parameter has not been preserved
Comment 1 Sam Reed (reedy) 2010-12-01 23:43:12 UTC
Interestingly, the other way round works...
Comment 2 Sam Reed (reedy) 2010-12-01 23:57:28 UTC
Actually, this seems to work on the SVN version.

http://192.168.0.190/wiki/Special:Code/MediaWiki/author/reedy

enter: /trunk/extensions/CodeReview/

We end up at http://192.168.0.190/w/index.php?path=/trunk/extensions/CodeReview/&title=Special:Code/MediaWiki&limit=50&title=Special:Code/MediaWiki/author/reedy

Still filtering by user

So that is actually fixed/invalid


Clicking a path in the list view though, ignores the filter. Which, I suppose, it should still honour?
Comment 3 Sam Reed (reedy) 2010-12-02 00:05:08 UTC
Logged bug 26195 for the silly parameter thing.

Please let me know if you want clicking on revisions in the list to keep the filter ( I can't sensibly think atm whether it should...? )

And then we can work out whether to close this, or we need to look at fixing this other part
Comment 4 Krinkle 2010-12-02 03:28:24 UTC
I don't run an svn checkout of CodeReview, but if you say the situation described in my initial comment is fixed, then I'm fine with this being closed.

Clicking a link (not pressing enter and/or submitting a form) makes me expect that I'm going to somewhere else and current filter/settings are ignored/unrelated to that.

However, the logic of other (core) Special:-pages with filters (such as RecentChanges and NewPages) - do do that. They manipulate filters mostly by links, not form elements (which is actually inefficient, since that requires multiple reloads when changing multiple settings, but that's for another bug).
Meaning, user expectation, based on the bahaviour of core Special:-pages, may be to preserve that. I can understand to choose to preserve author-filter when clicking a Path-link, even though I personally (like you) can't think why it should.

If anyone believes that it should preserve form values on links, feel free to re-open this bug.
For now closing becuase of FIXED in trunk.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links