Last modified: 2010-12-24 01:30:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28131, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26131 - Extension style-sheets are loaded after user style-sheets.
Extension style-sheets are loaded after user style-sheets.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-26 19:26 UTC by Mark Clements (HappyDog)
Modified: 2010-12-24 01:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Clements (HappyDog) 2010-11-26 19:26:02 UTC
I have just switched from REL_1_16 to trunk.  I have the CodeReview extension installed, and have a bunch of local CSS rules (in [[MediaWiki:Common.css]]) which customise the styling of the CodeReview output.

In 1.16, before the resource loader was added, the load order for CSS stylesheets was extensions, then core, then user styles.

In trunk, this appears to have changed to be core, user styles, extensions.

The correct order shold be core, extensions, user styles.

The current situation means that my local styles are being over-ridden by the default CodeReview stylings, and there is no way to get round this - I can't even use !important, as the CodeReview styles are already using this!
Comment 1 Mark Clements (HappyDog) 2010-11-26 19:36:25 UTC
*** Bug 26128 has been marked as a duplicate of this bug. ***
Comment 2 Mark Clements (HappyDog) 2010-11-26 19:37:16 UTC
(From bug 26128, comment #1, by Aaron Schulz)
> Probably caused by r75331.
Comment 3 Roan Kattouw 2010-11-30 14:41:06 UTC
We should force user scripts and styles to be the absolute last thing on the page; apparently we're not doing a good enough job of that right now.
Comment 4 Bergi 2010-12-01 17:55:08 UTC
Its the same with the liquid-thread-extension (tried at http://translatewiki.net). I needed to put a !important behind the "corrections".
Comment 5 Trevor Parscal 2010-12-04 00:00:47 UTC
r77693 resolves this by adding user and user.options scripts at the end of the body, and pushing any user* modules to the end of the head.
Comment 6 Roan Kattouw 2010-12-24 01:30:56 UTC
(In reply to comment #5)
> r77693 resolves this by adding user and user.options scripts at the end of the
> body, and pushing any user* modules to the end of the head.
This didn't actually work because dynamically added <style> tags were still being added below the <link> tag for user styles. Really fixed in r78943.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links