Last modified: 2010-12-14 17:15:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28128, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26128 - flaggedrevs.css loaded after site and user CSS
flaggedrevs.css loaded after site and user CSS
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Priyanka Dhanda
:
Depends on:
Blocks: 26334
  Show dependency treegraph
 
Reported: 2010-11-26 17:29 UTC by entlinkt
Modified: 2010-12-14 17:15 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description entlinkt 2010-11-26 17:29:36 UTC
Since a few days (possibly caused by the fix of bug 25289), flaggedrevs.css is being loaded after the site and user CSS.

This has broken 1 site-wide customization on dewiki (cf. http://de.wikipedia.org/w/index.php?title=MediaWiki:Monobook.css&diff=81917389&oldid=81917139) and an unknown number of user customizations.
Comment 1 Aaron Schulz 2010-11-26 19:30:52 UTC
Probably caused by r75331.
Comment 2 Mark Clements (HappyDog) 2010-11-26 19:36:25 UTC

*** This bug has been marked as a duplicate of bug 26131 ***
Comment 3 Aaron Schulz 2010-11-30 20:06:37 UTC
(In reply to comment #2)
> 
> *** This bug has been marked as a duplicate of bug 26131 ***

This isn't really a duplicate of whatever that bug is (Is it about current ext code or one the uses proper RL module registration). This is about code that should work properly on /deployment.
Comment 4 Mark Clements (HappyDog) 2010-11-30 22:55:22 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > 
> > *** This bug has been marked as a duplicate of bug 26131 ***
> 
> This isn't really a duplicate of whatever that bug is (Is it about current ext
> code or one the uses proper RL module registration). This is about code that
> should work properly on /deployment.

Well, unless it's just a coincidence, this seems to be a very specific example of the general bug described in bug 26131.  The resource loader is getting the order of extension stylesheets wrong so that they are loaded after user stylesheets.  

I'm not going to mark it as a dupe a second time, because perhaps you know something I don't, but they seem like the same bug to me.
Comment 5 Roan Kattouw 2010-12-01 19:15:13 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > 
> > *** This bug has been marked as a duplicate of bug 26131 ***
> 
> This isn't really a duplicate of whatever that bug is (Is it about current ext
> code or one the uses proper RL module registration). This is about code that
> should work properly on /deployment.

Aaah, this bug is about *deployment*. Yeah then this can't possibly be a dupe, as RL isn't in deployment.
Comment 6 Rob Lanphier 2010-12-06 21:26:54 UTC
Assigning to Priyanka to investigate further.
Comment 7 Priyanka Dhanda 2010-12-08 23:08:45 UTC
Fixed in trunk and branches/priyanka-wmf-fixes which contains fixes for the next deployment.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links