Last modified: 2010-11-25 23:09:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 26110 - Using the API for review does not work
Using the API for review does not work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-24 22:53 UTC by Hannes Roest
Modified: 2010-11-25 23:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
file to reproduce the error (421 bytes, text/x-python)
2010-11-24 22:53 UTC, Hannes Roest
Details

Description Hannes Roest 2010-11-24 22:53:52 UTC
Created attachment 7868 [details]
file to reproduce the error

When trying to review a revision through the API, I get an 500 Internal Server Error instead of any sensible response. Attached is a minimal python script that works with a freshly installed pywikibot to reproduce the error.

I also describe the problem here: http://en.wikipedia.org/wiki/Wikipedia:Pending_changes/Feedback#Problems_using_the_API
Comment 1 Sam Reed (reedy) 2010-11-24 22:55:54 UTC
I guess I've fixed it in r77258/r77260
Comment 2 Rob Lanphier 2010-11-24 23:00:21 UTC
Hi Hannes, thanks for reporting this!  Could you try testing against http://prototype.wikimedia.org/de-wp/api.php  (http://prototype.wikimedia.org/de.wikipedia.org ).  It should be fixed there, and if we confirm, that'll make it that much easier to deploy the fix.
Comment 3 Rob Lanphier 2010-11-24 23:00:52 UTC
Assigning to Chad to deploy.
Comment 4 Aaron Schulz 2010-11-25 01:19:00 UTC
(In reply to comment #1)
> I guess I've fixed it in r77258/r77260

Looks OK.
Comment 5 Aaron Schulz 2010-11-25 01:37:14 UTC
Deployed.
Comment 6 Hannes Roest 2010-11-25 09:17:19 UTC
Hi Rob, 

thanks for the quick response. I will be gone for a week and wont have a chance to test further but it seems that the problem is not quite solved. The internal server error has disappeared but now I get this:

<?xml version="1.0"?><api><error code="notarget" info="Cannot find a flagged revision with the specified ID." /></api>

whereas the specified revision clearly exists:

http://de.wikipedia.org/w/index.php?oldid=81798619

I have registered for the proteotype wiki, but dont have review rights - so I cannot test there either...maybe you can give me the rights? http://prototype.wikimedia.org/de.wikipedia.org/Benutzer:Hannes_R%C3%B6st

The ultimate test for me or you to do is to run the pywikipediabot and try to review a page only given its revision id. Might it be possible to run such a  test automatically for each mediawiki-version that is deployed? 

I also dont think I understand the suggested fix above. The error message produced on line 114  does not seem to relate to de-approving as suggested by the comments or am I mistaken? (if I am correct and the above message is produced by code on line 114). It might also be nice to distinguish it from a failure on line 50 where the error message seems to be correct and some other problem occurred with generating a Revision object from Revision::newFromId().

Greetings, 

Hannes
Comment 7 Aaron Schulz 2010-11-25 10:50:06 UTC
(In reply to comment #1)
> I guess I've fixed it in r77258/r77260

After looking at this again and doing API tests on a private wiki, I found a good amount of other outdated code too. Fixed in r77276.
Comment 8 Bawolff (Brian Wolff) 2010-11-25 18:45:06 UTC
(In reply to comment #7)
> (In reply to comment #1)
> > I guess I've fixed it in r77258/r77260
> 
> After looking at this again and doing API tests on a private wiki, I found a
> good amount of other outdated code too. Fixed in r77276.

Could said fixes be deployed? en.wikinews has some gadgets that are in quite heavy use that depend on sighting things by the api.
Comment 9 Aaron Schulz 2010-11-25 20:10:05 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #1)
> > > I guess I've fixed it in r77258/r77260
> > 
> > After looking at this again and doing API tests on a private wiki, I found a
> > good amount of other outdated code too. Fixed in r77276.
> 
> Could said fixes be deployed? en.wikinews has some gadgets that are in quite
> heavy use that depend on sighting things by the api.

Deployed.
Comment 10 Hannes Roest 2010-11-25 22:24:10 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #1)
> > > > I guess I've fixed it in r77258/r77260
> > > 
> > > After looking at this again and doing API tests on a private wiki, I found a
> > > good amount of other outdated code too. Fixed in r77276.
> > 
> > Could said fixes be deployed? en.wikinews has some gadgets that are in quite
> > heavy use that depend on sighting things by the api.
> 
> Deployed.


As far as I can tell, the functionality is restored. http://de.wikipedia.org/w/index.php?title=Hans_und_Annemarie_Hubacher&action=history was succesfully reviewed ...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links