Last modified: 2013-06-18 15:09:28 UTC
The text box to "remove tags" is a bit daft. A cross or similar next to it would be nicer...
Just a single tags section with some jquery to list them, tumblr style perhaps? (No idea what the tags section actually looks like)
Doing a API request against action=coderevisionupdate to remove the tag would do it... So it's another AJAXy type front end addition...
Going to code something. The UI will probably be crappy though :/
(In reply to comment #0) > The text box to "remove tags" is a bit daft. A cross or similar next to it > would be nicer... What could be simpler than a textbox?
(In reply to comment #4) > (In reply to comment #0) > > The text box to "remove tags" is a bit daft. A cross or similar next to it > > would be nicer... > > What could be simpler than a textbox? Laziness - Why should I have to write out (or copy paste) the tag name and click save?
For the Gadget Manager I'm currently working on a method that I call propCloud. Basically it's meant for adding, removing and changing items in a form that are actually an array. In my case it's an array of modules (the dependencies-array as seen in ResourceLoader module definitions). It shows a little cloud with <div>'s that are the items. Then a text area next to it (with autocompletion) and on-enter, selection of suggestions or click on {add} it adds it to the cloud as a <div> and clears the input field. In the gadget manager it only does an ajax request when the page is saved, but the callback could also make an ajax request right away. Adding this to Codereview would be cool. One thing to keep in mind: No conflict resolution exists in CodeReview, so when you add this via AJAX and then leave a comment (which isn't AJAX but submits the entire form), would it mess with the tags ?
Oh, right. Tags aren't in issue there (when saving a comment). It's the status changes that sometimes mess up: * Brion opens page * Chad opens page * Brion changes status and submits * Chad continous reading, writes a comment and submits * Chad reverted Brion's status change without knowing. -- anyway, that's NOT related...
(In reply to comment #7) > Oh, right. Tags aren't in issue there (when saving a comment). It's the status > changes that sometimes mess up: > * Brion opens page > * Chad opens page > * Brion changes status and submits > * Chad continous reading, writes a comment and submits > * Chad reverted Brion's status change without knowing. > > -- anyway, that's NOT related... Indeed its not... that is Bug 27886
I have sent my crappy UI with r96158 & r96159.
(In reply to comment #9) > I have sent my crappy UI with r96158 & r96159. 'Tis done.
