Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28075, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 26075 - ArticleDelete hook called with $error as value, should be reference

Summary:	ArticleDelete hook called with $error as value, should be reference

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: API (Other open bugs) Version: 1.17.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Roan Kattouw URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2010-11-23 09:49 UTC by Nikola Kovacs Modified: 2011-06-19 22:08 UTC (History) CC List: 5 users (show) Bryan.TongMinh sam soxred93 vasilvv wikibugs See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Nikola Kovacs 2010-11-23 09:49:47 UTC ApiDelete.php calls the ArticleDelete hook with the $error parameter as a value. This breaks pywikipediabot's delete.py when (for example) AbuseFilter is installed, since $error should be a reference. Comment 1 Alexandre Emsenhuber [IAlex] 2010-11-23 10:04:57 UTC Fixed in r77141. Comment 2 Nikola Kovacs 2011-06-19 17:35:53 UTC Why hasn't this been backported to MW 1.16? Comment 3 Sam Reed (reedy) 2011-06-19 22:08:46 UTC (In reply to comment #2) > Why hasn't this been backported to MW 1.16? The simple answer to that, is there was no explicit request to.