Last modified: 2012-08-20 14:16:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28069, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 26069 - <title> element is "Error" for all error pages


Summary:	<title> element is "Error" for all error pages

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Karun

URL:	http://commons.prototype.wikimedia.or...
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-11-23 07:31 UTC by Calcey QA
Modified:	2012-08-20 14:16 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
HeadingError (67.83 KB, image/png) 2010-11-23 07:31 UTC, Calcey QA	Details
Patch to change the header for error pages (827 bytes, patch) 2011-11-10 11:37 UTC, Karun	Details
second version of patch to provide a better error page title (1.38 KB, patch) 2011-11-10 11:54 UTC, Karun	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Calcey QA 2010-11-23 07:31:20 UTC

Page heading comes as Error for not logged in user. Better to change it to a more meaningful heading.

Please refer the attached screenshot.

Comment 1 Calcey QA 2010-11-23 07:31:52 UTC

Created attachment 7852 [details]
HeadingError

Comment 2 Roan Kattouw 2010-11-30 13:31:17 UTC

This is the case for all MediaWiki error pages.

Comment 3 Karun 2011-11-10 11:37:45 UTC

Created attachment 9407 [details]
Patch to change the header for error pages

I propose that for the error pages we have a title like Error: No such special pages, rather than only Error.

the patch attached does this. please review it.

Comment 4 Alexandre Emsenhuber [IAlex] 2011-11-10 11:40:39 UTC

The second parameter to prepareErrorPage() could also simply be removed.

Comment 5 Karun 2011-11-10 11:54:16 UTC

Created attachment 9408 [details]
second version of patch to provide a better error page title

I have modified this patch as suggested to only have one argument for prepareErrorPage, and provide a better error title.

Comment 6 Sumana Harihareswara 2012-05-25 02:32:45 UTC

Karun, thank you for the patch.  Are you interested in using developer access to directly suggest it into our Git source control system?

https://www.mediawiki.org/wiki/Developer_access

Comment 7 Alexandre Emsenhuber [IAlex] 2012-08-20 13:58:53 UTC

Now merged.

Comment 8 Sumana Harihareswara 2012-08-20 14:16:49 UTC

For the record: was merged as https://gerrit.wikimedia.org/r/#/c/20530/ . Thanks, Karun & iAlex.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links