Last modified: 2010-12-03 19:48:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28061, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26061 - CodeReview API need to give info for a list of revisions
CodeReview API need to give info for a list of revisions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-22 21:24 UTC by Antoine "hashar" Musso (WMF)
Modified: 2010-12-03 19:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2010-11-22 21:24:32 UTC
Given a revision list, there is currently no way to get their status, timestamp, author ...
The list system works by timestamp ordering, not for an arbitrary list of revisions.

Example usage :
When tracking pending merges, the list of revisions is not contiguous. It might be
useful to get those revisions status to check if we can safely merge them.

 $ svn mergeinfo --show-revs eligible   trunk/extensions/CodeReview branches/wmf/1.16wmf4/extensions/CodeReview
Comment 1 Sam Reed (reedy) 2010-12-02 20:30:40 UTC
Just wondering how best to limit this.

Technically, if we do it like the GUI, one call should give one set of detailed results..

Obviously, any call for a specific revs(s), should override the range one from before...

Do we want to limit the request for more detailed results to 1 rev, or just a low number?
Comment 2 Sam Reed (reedy) 2010-12-03 02:15:16 UTC
I've essentially done this, just need to work out some form of query "limit".

Do you want any additional information, or just what's there already?

Current: revid|status|commentcount|path|message|author|timestamp

Give me a shout =)

I'm just wondering if using a "trivial number", like 10..

e.g.

			'revs' => array(
				ApiBase::PARAM_ISMULTI => true,
				ApiBase::PARAM_TYPE => 'integer',
				ApiBase::PARAM_MIN => 1,
				ApiBase::PARAM_MAX => 10,
				ApiBase::PARAM_MAX2 => 10
			),
Comment 3 Sam Reed (reedy) 2010-12-03 14:30:07 UTC
Ignore that MAX/MAX2 stuff, that's me being stupid
Comment 4 Sam Reed (reedy) 2010-12-03 15:32:48 UTC
r77664
Comment 5 Antoine "hashar" Musso (WMF) 2010-12-03 19:48:08 UTC
Thanks Reedy!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links