Last modified: 2012-04-12 13:54:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28052, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 26052 - pagelink-depth parameter is broken
pagelink-depth parameter is broken
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-22 10:30 UTC by Robert Morley
Modified: 2012-04-12 13:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Robert Morley 2010-11-22 10:30:16 UTC 
I'm no PHP expert, but the new pagelink-depth parameter in Special:Export appears to be broken. Specifically, it seems to rely on a check against $linkDepth, but $linkDepth is unused outside that one if statement.
Comment 1 Alexandre Emsenhuber [IAlex] 2010-11-22 11:52:52 UTC 
The if block in includes/specials/SpecialExport.php on line 214 is not a comparaison between $linkDepth and $this->pageLinkDepth but an assignment (only one "="), and thus the check is only against $this->pageLinkDepth to see if it's zero or not. See r1=74745&r2=75767">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialExport.php?r1=74745&r2=75767 where the code was modified to be more readable.
Comment 2 Alexandre Emsenhuber [IAlex] 2010-11-22 11:57:38 UTC 
Seems bugzilla didn't like the URL, see r75767 and then select the correct file.
Comment 3 Robert Morley 2010-11-22 19:58:16 UTC 
I'd missed that. Now I see what's going on. Thanks! I still wasn't able to get it to work in testing, but maybe I goofed somewhere.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links