Last modified: 2012-07-30 09:07:25 UTC
With $wgEmailConfirmToEdit = true; the RSS and Atom Recent Changes feeds don't have diffs. (Same with individual pages' history.) I checked that setting $wgEmailConfirmToEditor to false restores the diffs. I attached a patch that restoers the diffs, but I'm not sure it's the right thing.
Looks like the patch fell off, can you re-attach? Thanks!
Created attachment 7840 [details] Patch to ignore 'confirmedittext' as a reason not to show a diff.
Created attachment 7841 [details] Patch to change Title::getUserPermissionsErrors() to make correct checks for read permission The problem is bigger that this. Title::getUserPermissionsErrors() is not supposed to be used to check for read permissions; but Title::userCanRead() can only check permissions for $wgUser. I attached a patch to make Title::getUserPermissionsErrors() check correctly for read permissions; dunno if Domas will like it since it's ~1.4 times slower than the old method (on my local machine).
*** Bug 29482 has been marked as a duplicate of this bug. ***
Fixed in r102187.
*** Bug 38709 has been marked as a duplicate of this bug. ***