Last modified: 2012-07-30 09:07:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T28020, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 26020 - $wgEmailConfirmToEdit removes diffs from Recent Changes feeds (RSS and Atom)
$wgEmailConfirmToEdit removes diffs from Recent Changes feeds (RSS and Atom)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
: 29482 38709 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-19 23:41 UTC by David Fifield
Modified: 2012-07-30 09:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to ignore 'confirmedittext' as a reason not to show a diff. (599 bytes, patch)
2010-11-20 00:07 UTC, David Fifield
Details
Patch to change Title::getUserPermissionsErrors() to make correct checks for read permission (7.56 KB, patch)
2010-11-20 12:31 UTC, Alexandre Emsenhuber [IAlex]
Details

Description David Fifield 2010-11-19 23:41:37 UTC
With

$wgEmailConfirmToEdit = true;

the RSS and Atom Recent Changes feeds don't have diffs. (Same with individual pages' history.) I checked that setting $wgEmailConfirmToEditor to false restores the diffs. I attached a patch that restoers the diffs, but I'm not sure it's the right thing.
Comment 1 Brion Vibber 2010-11-19 23:47:50 UTC
Looks like the patch fell off, can you re-attach? Thanks!
Comment 2 David Fifield 2010-11-20 00:07:08 UTC
Created attachment 7840 [details]
Patch to ignore 'confirmedittext' as a reason not to show a diff.
Comment 3 Alexandre Emsenhuber [IAlex] 2010-11-20 12:31:54 UTC
Created attachment 7841 [details]
Patch to change Title::getUserPermissionsErrors() to make correct checks for read permission

The problem is bigger that this. Title::getUserPermissionsErrors() is not supposed to be used to check for read permissions; but Title::userCanRead() can only check permissions for $wgUser.

I attached a patch to make Title::getUserPermissionsErrors() check correctly for read permissions; dunno if Domas will like it since it's ~1.4 times slower than the old method (on my local machine).
Comment 4 Sumana Harihareswara 2011-10-07 19:42:08 UTC
*** Bug 29482 has been marked as a duplicate of this bug. ***
Comment 5 Alexandre Emsenhuber [IAlex] 2011-11-06 20:00:15 UTC
Fixed in r102187.
Comment 6 Alexandre Emsenhuber [IAlex] 2012-07-30 09:07:25 UTC
*** Bug 38709 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links