Last modified: 2010-12-06 01:35:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27993, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25993 - LQT doesn't throw an error if user is not allowed to edit.
LQT doesn't throw an error if user is not allowed to edit.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-18 16:26 UTC by admin
Modified: 2010-12-06 01:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description admin 2010-11-18 16:26:58 UTC
Setting is that anons are not allowed to start a discussion, neither may they reply to an existing (in LocalSettings by "$wgGroupPermissions['*']['createtalk']=false"). When they nevertheless try to, there is no error message, but the spinning wheel appears. That is misleading, because it rather suggests a software problem than that the user is trying something he is not permitted to. When afterwards trying to move to a different location, the browser crashes.

You can reproduce this: Go here http://k6.juniorwiki.org/index.php?title=Diskussion:Ring. Then try to start a new discussion or to reply to a message. Be aware that the browser may crash, when you try to move on from there afterwards.

Running MW1.16, LiquidThreads2.0-alpha
Comment 1 DieBuche 2010-12-05 17:43:56 UTC
Which browser crashed, I can't reproduce with chrome? I can reproduce the spinning wheel though:
lqt.js:227  Uncaught TypeError: Cannot read property 'inlineeditform' of undefined
Comment 2 admin 2010-12-05 18:22:38 UTC
(In reply to comment #1)
> Which browser crashed, I can't reproduce with chrome? I can reproduce the
> spinning wheel though:
> lqt.js:227  Uncaught TypeError: Cannot read property 'inlineeditform' of
> undefined

Crashing browser is FF (3.6).
Opera doesn't crash, either.

Just tested again, now FF didn't crash. So crashing browser was: FF.

Error is:

"result.threadaction is undefined.
var content = $j(result.threadaction.inlineeditform.html);
lqt.js line 227."
Comment 3 DieBuche 2010-12-05 19:59:47 UTC
API result:
{"query":{"pages":{"-1":{"ns":0,"title":"Some Title","missing":"","starttimestamp":"2010-12-05T19:56:34Z"}}},"warnings":{"info":{"*":"Action 'edit' is not allowed for the current user"}}}

Does LQT has any error-handling at all?
Comment 4 Andrew Garrett 2010-12-05 23:11:28 UTC
(In reply to comment #3)
> API result:
> {"query":{"pages":{"-1":{"ns":0,"title":"Some
> Title","missing":"","starttimestamp":"2010-12-05T19:56:34Z"}}},"warnings":{"info":{"*":"Action
> 'edit' is not allowed for the current user"}}}
> 
> Does LQT has any error-handling at all?

This should be caught, but apparently isn't. I'll take a look later today.
Comment 5 Andrew Garrett 2010-12-06 01:35:05 UTC
Should now be fixed, and the buttons now do not show up in the first place.

Thanks for reporting this bug. Please let me know if you continue to encounter it after updating to r77850.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links