Last modified: 2006-06-22 20:21:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2598 - only one blacklist file is parsed by SpamBlacklist extension
only one blacklist file is parsed by SpamBlacklist extension
Status: RESOLVED DUPLICATE of bug 1673
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 4462
  Show dependency treegraph
 
Reported: 2005-06-29 01:23 UTC by Brad Will (tmbw.net)
Modified: 2006-06-22 20:21 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Use array_merge instead of += operator to merge wordlists. (1.04 KB, patch)
2005-10-26 16:23 UTC, Mario Manno
Details

Description Brad Will (tmbw.net) 2005-06-29 01:23:32 UTC
I have tried putting entries in the local_blacklist file and the SpamBlacklist
page in my wiki both with and without pre tags wrapped around the list;
backslashes escaping dots in the URLs, etc, and it just doesn't work no matter
what - the wikimedia_blacklist is the only one that gets parsed. Neither entries
in the local_blacklist file nor in the SpamBlacklist page in the wiki itself are
actually blacklisted in practice, although - interestingly - if you screw up the
database name in the one pointing to the wiki page you WILL get script errors
whenever you try to post new edits. So I'm not quite sure where the bug is, but
I'd REALLY like to see it get fixed, so that I could maintain a local blacklist
that wouldn't get wiped out any time I fetched a new copy of mediawiki's own
blacklist.
Comment 1 Brad Will (tmbw.net) 2005-06-29 01:27:29 UTC
Note - this might be not be an issue of the extension not handling multiple
files.  I have successfully had it work with a couple smaller files.  It could
be that the total KB of the combined files gets too large.  Just a theory
Comment 2 Rick DeNatale 2005-06-29 15:44:35 UTC
Which order do you have the files listed?  I found that putting the mediawiki
file last worked for me.
For some reason the extension didn't go past it.

This was true for both files and my local Spamblacklist article in the DB.

I do notice that the downloaded mediawiki spam blacklist file doesn't seem to
end with a newline, perhaps this is the problem?!?
Comment 3 Brad Will (tmbw.net) 2005-06-29 17:36:44 UTC
(In reply to comment #2)
> Which order do you have the files listed?  I found that putting the mediawiki
> file last worked for me.

I have tried all orders, and while it seems to have weird effects, based on the
ordering, it's not consistent.  I also decided to combined all 3 blacklists into
a single file, and just use that one file in the local settings, and that didn't
work either.  This is why i'm wondering if it's a problem with the size of the
combined file(s)

> 
> I do notice that the downloaded mediawiki spam blacklist file doesn't seem to
> end with a newline, perhaps this is the problem?!?

I tried adding a new line, as i was wondering about that also, and that didn't
have any affect. 
Comment 4 Zigger 2005-06-29 20:01:29 UTC
Is this a duplicate of bug 1673?
Comment 5 Brad Will (tmbw.net) 2005-06-29 20:20:16 UTC
(In reply to comment #4)
> Is this a duplicate of bug 1673?

It's possible.  However, the proposed patch is out-of-date, so can someone
re-apply the patch to the new code, so that we can test it out?
Comment 6 Mario Manno 2005-10-26 16:23:39 UTC
Created attachment 1020 [details]
Use array_merge instead of += operator to merge wordlists.

I think it works. Let me post an updated patch...
Comment 7 Brion Vibber 2006-06-22 20:21:48 UTC

*** This bug has been marked as a duplicate of 1673 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links