Last modified: 2011-02-20 23:55:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27977, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25977 - Duplicate messages in FlaggedRevs
Duplicate messages in FlaggedRevs
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Brandon Harris
:
Depends on:
Blocks: 26335
  Show dependency treegraph
 
Reported: 2010-11-17 16:56 UTC by Leinad
Modified: 2011-02-20 23:55 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
2 similar messages (208.71 KB, image/png)
2010-11-17 16:56 UTC, Leinad
Details

Description Leinad 2010-11-17 16:56:34 UTC
Created attachment 7826 [details]
2 similar messages

[[MediaWiki:Revreview-pendingnotice]] and [[MediaWiki:Revreview-newest-basic]] are very similar (look at attachment).

It would be useful to merge or reword these messages.
Comment 1 Aaron Schulz 2010-11-17 17:02:29 UTC
They should not show simultaneously. If the bar UI is enabled, then the new r76835 message probably just should not show.
Comment 2 Rob Lanphier 2010-11-23 20:41:56 UTC
Phooey...this one slipped through the cracks.  Assigning to Priyanka to see if there's something quick we can do here.
Comment 3 Rob Lanphier 2010-11-23 21:12:12 UTC
I think this one may be fixed by r76895 (if so, it didn't slip through the cracks after all..yay!)
Comment 4 Aaron Schulz 2010-11-23 21:30:45 UTC
(In reply to comment #3)
> I think this one may be fixed by r76895 (if so, it didn't slip through the
> cracks after all..yay!)

The never show at once, due to r76958.
Comment 5 Rob Lanphier 2010-11-23 21:36:34 UTC
Ok.  Let's call this done then.  Leinad, can you confirm this is fixed to your satisfaction by closing this?  (or reopening if it's not quite right?)
Comment 6 Leinad 2010-11-24 03:04:09 UTC
In my humble opinion sentences "It was last accepted at $1." and "The stable version was checked on $2." are very similar. And in both places we can see a date.

I would suggest merge these sentences and put in [[MediaWiki:Revreview-pendingnotice]]. And in [[MediaWiki:Revreview-newest-basic]] leave only sentence "There are $3 pending changes awaiting review.".
Comment 7 Rob Lanphier 2010-11-24 22:09:44 UTC
Looking at the screenshot made me realize that I was mixing this issue up with bug 25975.  Assigning to Brandon to get some guidance on this.
Comment 8 Aaron Schulz 2011-02-20 23:55:36 UTC
Merged in r82541.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links