Last modified: 2011-08-29 22:40:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27941, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25941 - Enhanced recent changes clobbers classes
Enhanced recent changes clobbers classes
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.17.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-15 22:29 UTC by J
Modified: 2011-08-29 22:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch detailed in description (407 bytes, patch)
2010-11-15 22:29 UTC, J
Details

Description J 2010-11-15 22:29:04 UTC
Created attachment 7819 [details]
patch detailed in description

Instead of adding/removing classes from elements, toggleVisiblity in enhancedchanges.js sets the full class attribute.  This conflicts with any third-party scripts that might set their own classes (and it was in writing such a script that I came across this).

I've attached a patch for skins/common/enhancedchanges.js, which fixes this for the #mw-rc-subentries- elements - I think it unlikely you'd need to mess with the arrows' classes, but fixing them is as easy.  Maybe it would also make sense to use similar RexEx to test for the arrow's class instead of "openarrow.className == 'mw-changeslist-expanded'"?
Comment 1 Krinkle 2011-02-09 00:45:51 UTC
This has been fixed already in december 2010.

A plugin was added to make an element collapsible  ($.fn.makeCollapsible() - added in r78914), which solved several problems, such as these since it doesn't replace but adds/removes classes.

skins/common/enhancedchanges.js was removed in favour of using makeCollapsible() in r79083.

Closing as fixed. Depending on how much of the recent ResourceLoader development will be merged to REL1_17 and/or 1.17wmf, this may not be live untill 1.18.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links