Last modified: 2012-04-12 13:53:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27833, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25833 - SpecialUpload: protected $mComment breaks SelectCategory extension
SpecialUpload: protected $mComment breaks SelectCategory extension
Status: RESOLVED DUPLICATE of bug 24981
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.16.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-08 01:05 UTC by Christian Boltz
Modified: 2012-04-12 13:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Boltz 2010-11-08 01:05:28 UTC
It looks like SpecialUpload was reworked in 1.16. Unfortunately the upload description is no longer available to other extensions (via hook).

This breaks the SelectCategory extension - the selected categories never end up in the image:... page because SelectCategory can't add them to the upload description. 

Therefore I propose the following patch:

Index: includes/specials/SpecialUpload.php
===================================================================
--- includes/specials/SpecialUpload.php (Revision 71214)
+++ includes/specials/SpecialUpload.php (Arbeitskopie)
@@ -31,7 +31,7 @@

        /** User input variables from the "description" section **/
        public    $mDesiredDestName;    // The requested target file name
-       protected $mComment;
+       public    $mComment;
        protected $mLicense;
 
        /** User input variables from the root section **/


If you want to fix this really backwards-compatible, there's another issue:
Older versions of Mediawiki used $m_pageObj->mUploadDescription   *)
In 1.16 it is named $m_pageObj->mComment.
Reverting this name change would be nice ;-)

*) $m_pageObj is the object passed over in the UploadForm:BeforeProcessing hook
Comment 1 Bryan Tong Minh 2010-11-08 07:50:21 UTC
This is fixed in r71903 and r71904 and will be available in the 1.16.1 release.

*** This bug has been marked as a duplicate of bug 24981 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links