Last modified: 2012-09-01 08:58:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27830, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25830 - LivePreview makes page "jump"
LivePreview makes page "jump"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 39272
  Show dependency treegraph
 
Reported: 2010-11-07 17:23 UTC by DieBuche
Modified: 2012-09-01 08:58 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch (1.25 KB, patch)
2010-11-07 17:23 UTC, DieBuche
Details

Description DieBuche 2010-11-07 17:23:31 UTC
Created attachment 7801 [details]
patch

When using the keyboard short cut the following happens:
1. Page is scrolled down to the height of preview button
2. As soon as the preview is loaded it's scrolled up

If preview is clicked a second time:
1. Old preview content is display:none -> page jumps
2. New content comes in -> page jumps

The provided patch fixes that irritating behaviour. Was in use at commonswiki for months.
Comment 1 Mark A. Hershberger 2011-02-09 23:02:34 UTC
Trevor, Michael,

Is this still outstanding?
Comment 2 Mark A. Hershberger 2011-02-10 02:06:19 UTC
I ask because it seems to be related to some other "my window is jumping around" bugs.
Comment 3 Mark A. Hershberger 2011-02-10 18:33:29 UTC
Bug #26679 also has complaints about jumpy windows.
Comment 4 Sumana Harihareswara 2011-11-09 04:08:02 UTC
DieBuche, I see that this patch no longer cleanly applies to trunk -- sorry.  I'm thus marking it reviewed.
Comment 5 Bartosz Dziewoński 2012-08-09 14:08:34 UTC
I fixed the patch (it just needed --ignore-whitespace to apply) and submitted to gerrit as I743ed45e039445242a99a23cad719a75731c5562.
Comment 6 Ryan Kaldari 2012-08-31 20:29:48 UTC
I was going to review the patch, but I can't reproduce the bug. Can someone post reproduction steps? Thanks.
Comment 7 Ryan Kaldari 2012-08-31 20:53:22 UTC
Nevermind, I see it now...

Preview an edit twice on a long article and you'll see the jumpiness.
Comment 8 Bartosz Dziewoński 2012-09-01 08:58:10 UTC
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links