Last modified: 2012-04-16 09:16:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27827, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25827 - includes/DefaultSettings.php has two different defaults for $wgPasswordSender
includes/DefaultSettings.php has two different defaults for $wgPasswordSender
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-07 14:40 UTC by Christian Boltz
Modified: 2012-04-16 09:16 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Boltz 2010-11-07 14:40:54 UTC
includes/DefaultSettings.php has two different defaults for $wgPasswordSender:

a) (line 520 in 1.16):

/**
 * Password reminder email address
 * The address we should use as sender when a user is requesting his password
 * Default to apache@SERVER_NAME
 */
$wgPasswordSender   = 'MediaWiki Mail <apache@' . $wgServerName . '>';

Note: this was changed in SVN trunk r76234 to:
$wgPasswordSender = 'apache@' . $serverName;

b) (line 1720 in 1.16):
/** For email notification on page changes */
$wgPasswordSender = $wgEmergencyContact;

This is highly confusing for people who read DefaultSettings.php. Even http://www.mediawiki.org/wiki/Manual:$wgPasswordSender 
has a section saying so ;-)

Please remove the first setting (it's always overriddenAFAIK) to remove that confusion.

Bonus points if you move the second/remaining one near the definition of $wgEmergencyContact so that it's easyer to see what the actual default value 
is ;-)
Comment 1 Alexandre Emsenhuber [IAlex] 2010-11-07 14:43:52 UTC
Already fixed in r76234.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links