Last modified: 2010-11-06 01:36:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 25790 - Less thumbnail downloads for InstantCommons
Less thumbnail downloads for InstantCommons
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.17.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-05 03:33 UTC by Derk-Jan Hartman
Modified: 2010-11-06 01:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
preserve files longer (4.69 KB, patch)
2010-11-05 03:33 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2010-11-05 03:33:01 UTC
Created attachment 7790 [details]
preserve files longer

Currently all thumbnails for InstantCommons are redownloaded when the api cache expires after 1 day. This is mostly done because these thumbs are not purged when a user uploads a new file on Commons.

However, from the api, we can get the timestamp of upload. This patch checks if there is already a file at the thumbnail location, checks to see if the commons timestamp is newer than the local thumb timestamp and then reuses that file, bypassing the need to download it from commons and to write it to disk again.

I have built in a new safety net at 1 month, though of course we could play with that. Should save upload.wikimedia.org some unneeded traffic, which with the more widely used InstantCommons surely cannot hurt.
Comment 1 Derk-Jan Hartman 2010-11-05 16:31:37 UTC
Applied in r76111

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links