Last modified: 2011-02-08 21:56:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27757, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25757 - Diff page loading seems to stall for logged-in users
Diff page loading seems to stall for logged-in users
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Rob Lanphier
:
Depends on:
Blocks: 25293 26334
  Show dependency treegraph
 
Reported: 2010-11-02 22:59 UTC by Rob Lanphier
Modified: 2011-02-08 21:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Lanphier 2010-11-02 22:59:26 UTC
The fix for bug 25289 (diff pages load slowly) seems to work well in Firefox, but seems to stall every other page load in Chrome.
Comment 1 Aaron Schulz 2010-11-17 09:52:39 UTC
(In reply to comment #0)
> The fix for bug 25289 (diff pages load slowly) seems to work well in Firefox,
> but seems to stall every other page load in Chrome.

Which version? Do you have a good example diff url? I'm not getting this on my testwiki.
Comment 2 Rob Lanphier 2010-11-18 01:45:51 UTC
Priyanka and I did some investigation on this, and it seems to be related to logged-in status rather than browser.  Changing summary to reflect.
Comment 3 Rob Lanphier 2010-11-18 01:51:55 UTC
Here's a repro:

Visit this page:
http://prototype.wikimedia.org/flaggedrevs-w/index.php?title=Pakistan&action=historysubmit&diff=12188&oldid=12186

...then click on "Previous edit"

When you're not logged-in, it loads right away.  When you are logged in, there's a long delay.
Comment 4 Aaron Schulz 2010-11-18 21:01:42 UTC
Seemed fast for me.
Comment 5 Krinkle 2010-11-18 21:09:44 UTC
Hm.. since when is the article below the diff loaded via ajax ? Seems a unnececary extra call ?
Comment 6 Rob Lanphier 2010-11-23 00:01:06 UTC
Krinkle: see bug 25289.  There are cases where the diff page takes a very long time to load due to the display of the later revision in the diff.  The old workaround (the diffonly option) is something that wasn't viewed as appropriate for use with Pending Changes (see bug 24315), and this solution let's us actually see the later revision eventually without stalling the diff display in the process.
Comment 7 Priyanka Dhanda 2010-12-10 22:55:33 UTC
After a conversation with Roan, seems that this was a problem we were seeing in prototype because we we not using our custom session storage that uses memcached.

Setting $wgSessionsInMemcached = true; fixed this in prototype.

Also r78212 should make the diffs load faster.
Comment 8 Priyanka Dhanda 2010-12-10 23:41:48 UTC
Merged r78212 and r78213 into  branches/priyanka-wmf-fixes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links