Last modified: 2010-11-02 15:14:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27749, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25749 - Comma should be internationalized in AbuseFilter user interface
Comma should be internationalized in AbuseFilter user interface
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Andrew Garrett
: easy, i18n
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-02 04:00 UTC by Huji
Modified: 2010-11-02 15:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Huji 2010-11-02 04:00:19 UTC 
The comma separating the phrases under "Consequences" column in the AbuseFilter home is hard-coded and not internationalized. To be compliant with MediaWiki standards, it should be i18ned.
Comment 1 Siebrand Mazeland 2010-11-02 15:14:36 UTC 
Not sure which version has been deployed at Wikimedia at the moment, but the below piece of code that is currently in trunk suggests this is being done (r63691 / March 13, 2010):
case 'af_actions':
	$actions = explode( ',', $value );
	$displayActions = array();
	foreach ( $actions as $action ) {
		$displayActions[] = AbuseFilter::getActionDisplay( $action );
	}
	return htmlspecialchars( $wgLang->commaList( $displayActions ) );

Wikimedia is running some pretty old code...

Closing as works for me.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links