Last modified: 2010-11-01 14:33:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27735, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25735 - preg cannot compile patters in CSSMin.php
preg cannot compile patters in CSSMin.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All Linux
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-01 08:21 UTC by Paul Oranje
Modified: 2010-11-01 14:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
adjusts patterns to use old syntax for naming subpatterns (1.08 KB, patch)
2010-11-01 08:21 UTC, Paul Oranje
Details

Description Paul Oranje 2010-11-01 08:21:39 UTC
Created attachment 7772 [details]
adjusts patterns to use old syntax for naming subpatterns

The preg syntax for patterns allows naming of subpartterns.
When using preg with version < 5.2.2 the syntax used by CSSMin (?<name>) isn't supported. The older syntax (?P<name>) can be used on all versions though; so please use that (patch attached).

See also http://php.net/manual/en/function.preg-match.php.
Comment 1 Roan Kattouw 2010-11-01 14:33:38 UTC
Patch applied in r75792, thanks.

The attached patch was reversed and left the old lines commented out rather than removing them. Use the "svn diff" command to produce a diff from an SVN checkout.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links