Last modified: 2010-11-07 09:31:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27728, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25728 - Mail sender ("WikiAdmin") should be configurable
Mail sender ("WikiAdmin") should be configurable
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Email (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 25802 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-31 19:15 UTC by Christian Boltz
Modified: 2010-11-07 09:31 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Boltz 2010-10-31 19:15:02 UTC
Mediawiki sends all notification mails about changed pages using the sender name "WikiAdmin". 

This is hardcoded in includes/UserMailer.php, line 484:
    $adminAddress = new MailAddress( $wgPasswordSender, 'WikiAdmin' );

Now imagine you are working on multiple wikis - all will send you mails with the sender name "WikiAdmin", only the sender mail address differs ($wgPasswordSender).

Please replace the hardcoded "WikiAdmin" with a configurable variable (which would default to WikiAdmin). Something like this:
    $adminAddress = new MailAddress( $wgPasswordSender, $wgPasswordSenderName );
Comment 1 Alexandre Emsenhuber [IAlex] 2010-11-06 20:32:34 UTC
*** Bug 25802 has been marked as a duplicate of this bug. ***
Comment 2 Gerard Boyers 2010-11-06 23:49:54 UTC
I agree. This variable could alternatively default to $wgSiteName to ease adoption.
Comment 3 Platonides 2010-11-06 23:59:47 UTC
I think we should allow $wgPasswordSender to be 'WikiOneo Admin <wiki1@myserver.com>'.

The default $wgPasswordSender IS 'MediaWiki Mail <apache@serverName>' but that's not supported by MailAddress class, producing "WikiAdmin <MediaWiki Mail <apache@serverName>>"
Comment 4 Alexandre Emsenhuber [IAlex] 2010-11-07 09:31:10 UTC
Done in r76234.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links