Last modified: 2008-04-24 01:46:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2571 - Duplicate anchors and missing form id tag in search form on Cologne Blue skin
Duplicate anchors and missing form id tag in search form on Cologne Blue skin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: html
  Show dependency treegraph
 
Reported: 2005-06-28 14:30 UTC by Zigger
Modified: 2008-04-24 01:46 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Zigger 2005-06-28 14:30:37 UTC
The Cologne Blue skin sets the search form tag to have the attribute id="search"
and the input tag to also have the attribute name="search", since at least v1.3.

Monobook corrects this by giving the form an 'id' (and 'name') of "searchform",
ensuring that the relevant tags have unique anchors.  (However the 'name'
attribute is deprecated for 'form' tags in XHTML 1.0.)

References:

XHTML 1.0 : http://www.w3.org/TR/xhtml1/#h-4.10
            http://www.w3.org/TR/xhtml1/#C_8

HTML 4.01 : http://www.w3.org/TR/html4/struct/links.html#h-12.2.1
            http://www.w3.org/TR/html4/struct/links.html#h-12.2.3

XML 1.0   : http://www.w3.org/TR/REC-xml/#sec-attribute-types
Comment 1 Zigger 2005-06-28 15:17:21 UTC
And the main duplication is that Cologne Blue outputs the same search form 'id'
attribute values in both the quick bar and the footer.
Comment 2 Antoine "hashar" Musso (WMF) 2006-01-08 18:18:20 UTC
Corrected the searchForm() function, the form and input now have their
own id. I also added a counter to give incremental id if several search
boxes are added.

Fixed in HEAD and 1.5, will be in 1.5.6
Comment 3 Brion Vibber 2006-01-09 05:13:40 UTC
Bogus fix destroyed search functionality in Cologne Blue skin, was obviously not tested. 
Reverted.
Comment 4 Brion Vibber 2008-04-24 01:46:33 UTC
This was fixed correctly some time ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links