Last modified: 2010-10-29 00:19:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27699, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25699 - Cached 1-click donation forms do not properly handle sessions
Cached 1-click donation forms do not properly handle sessions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DonationInterface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Arthur Richards
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-28 23:14 UTC by Arthur Richards
Modified: 2010-10-29 00:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Arthur Richards 2010-10-28 23:14:20 UTC 
It appears that when the AJAX request sets a user's session for a cached single-click donation page, a cookie with the user's session id is not getting set.  The result is that when a user attempts to click 'donate by paypal' or submit the credit card form, they will be told that their session has expired and are required to fill out the form again/try clicking the paypal button again.

It seems that there is a problem setting a PHP session via AJAX - a cookie with the session id does not get set on the user's system.  A simple solution would be to have the session id sent back in the AJAX request and have Javascript set the cookie for the user.

Also, as a side note, we should push the paypal redirect logic to happen /before/ token checking, since (particularly with slow connections) a user may hit the paypal button before the ajax has finished doing its session setting.
Comment 1 Arthur Richards 2010-10-29 00:19:57 UTC 
fixed in r75636
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links